J. Kissel, S. Dwyer, K. Izumi

As of LHO aLOG 10702, we'd identified that the sign convention for the lower two stage coil/magnet compensation of all HSTS and HLTS (i.e. the signs of the gains of the COILOUTF banks) had been wrong since basically forever, in that a +L request results in a -L. Today we've gone through each SUS, flipped the COILOUTF signs to obey convention, and compensated for the sign flip in all affected LSC loops (ASC loops are not affected, since we're only sending signals to the TOP mass at this point). We have since confirmed that the IMC re-locks and we've checked that PRMI stuff is OK by re-locking PRX.

We have captured all new safe.snaps for all the SUS and the LSC model, and subsquently committed all snaps and changes to guardian to the svn repo.

Change list:
(1) Changed sign in all M2 and M3 COILOUTF banks for 
MC1, MC2, MC3
PRM, PR2, PR3
SRM, SR2, SR3
to the following
        WAS     IS NOW
    UL   -        +
    LL   +        -
    UR   +        -
    LR   -        +

(2) For IMC L, we changed the analog sign on the slow (MCL) path in the IMC common mode board, just before the signal enters the LSC ADC, to change the overall sign of the LSC requested signal, as well as the top mass, M1 stage, LOCK filter sign, since it had already obeyed convention
                              WAS    IS NOW
H1:IMC-REFL_SERVO_SLOWPOL      -        +
H1:SUS-MC2_M1_LOCK_L_GAIN      +        -

(3) The IMC Guardian only touches the MC2 M1 LOCK L filter gain (to turn it on and off during lock acquisition), so we made sure that it sets the gain sign correctly.

(4) For the PRC, we changed the overall sign of the PRC loop in the LSC-PRCL bank, and then changed the MICH2PRM output matrix sign (the MICH2BS element is not affected, since it already obeyed convention).
                             WAS     IS NOW   
H1:LSC-PRCL_GAIN              -        +
H1:LSC-OUTPUT_MTRX_5_2        -        +

(5) We've modified the two Guardians responsible for PRX/PRY locking and 3f PRMI locking to make sure they set these gains correctly.
/opt/rtcds/userapps/release/lsc/h1/guardian/lsclib/prxy/carrierlock.py (PRX /PRY locking guardian)
/opt/rtcds/userapps/release/lsc/h1/guardian/lsclib/prmi/sidebandlock.py