thomas.shaffer@LIGO.ORG - posted 11:27, Thursday 04 February 2016 (25380)
ISI_ETMY_ST1_CONF GRD node created/started/tested/destroyed
WP#5722
While we have high useism I wanted to revisit how this node is doing since I haven't touched it since before ER8. I created, started the node, and then had it switch blends with no problem. I then tried to mess it up to see how it would react. This is where I left off last time.
Some of my tests:
- If I manually change the blend to one that was not set by the GRD node, then it will complain that it is not in the right configuration and then try to change it immediately. At this point the FE has control of the filter banks so the node cannot actually change the value of the banks. I will need to change the code to wait before trying to change it back, or maybe just jump to DOWN and notify that it isn't in the preferred configuration.
- The DOWN state works as it should. It will jump to it from any of the requestable states and then just sit there and not do anything. If a blend is manually changed while the node is in DOWN, it will simply just ignore it. The node is, well, down.
- INIT doesn't jump to the state that it should, I'm not 100% sure why yet, I have some guesses but need to investigate some more first. If INIT is selected, even if it is in a state that it just set, it will go to DOWN and then work its way throught the graph to the requested state.
- Stopping a node in the middle of the switch still allows the FE to finish the "blending", but the NXT banks do not get turned off at the end. I need to think of a way around this, though this situation shouldn't ever happen...(I'm sure someone will find a way)
- Chaning the name of the filter in the const.py, but with an incorrect filter bank number will cause it to change blends to the FB number but as soon as it is done it will complain that it is not in the right configuration and then try to get to the state again. I should add a quick check somewhere that will check that the name and FB number match.
Overall it went well and I have a few things to work on. When I get another chance to test this out I will try it on ETMX with the BRS SC as well, the BLENSCOR node as I have been calling it.