Displaying report 1-1 of 1.
Reports until 13:26, Friday 17 June 2016
H1 SEI (GRD)
jim.warner@LIGO.ORG - posted 13:26, Friday 17 June 2016 - last comment - 10:16, Monday 20 June 2016(27809)
Possible small code conflict in ISI guardian code

After Sheila's log about the BS causing locklosses, I wanted to check a few things in the guardian code and I found what looks like conflict in the code. In /opt/rtcds/userapps/release/isi/h1/guardian/  ISI_BS_ST2.py, line 4

ISOLATION_CONSTANTS['CART_BIAS_DOF_LISTS'] = ([ ] , [ ])

the empty brackets at the end indicate the ISI is not set to restore any Cartesian locations.  This is supposed to be the code that sets what dofs are restored when the ISI re-isolates, and is particular to the beamsplitter.

However, in  /opt/rtcds/userapps/release/isi/common/guardian/isiguardianlib/isolation/ CONST.py lines 102 (for BSC ST1) and 122 (for BSC ST2) both read

            CART_BIAS_DOF_LISTS = ([], ['RZ']),

CONST.py is common code, and I would interpret this to mean that all BSCs are restoring a stored RZ location. This isn't a problem for the other BSCs, because they never change state, but if we turn on the ST2 loops for the BS, this code could force the ISI to rotate some after the loops come on. The attached trend shows the last ten days of the BS ST2 RZ setpoint and locationmon, and they track each other, so I dont think the BS is returning to some old RZ location, but someone who understands this code should explain it to me.

Images attached to this report
Comments related to this report
thomas.shaffer@LIGO.ORG - 14:12, Friday 17 June 2016 (27810)

The CART_BIAS_DOF_LIST in the common code you could say is the "default" setting, but can be overwritten by the chamber node's local file (as is done here). The two empty lists in the local file show that there are no cartesian bias degrees of freedom being being restored.

A quick "grep CART_BIAS ./*.py" in (userapps)/isi/h1/guardian/ yields:



./ISI_BS_ST1.py:ISOLATION_CONSTANTS['CART_BIAS_DOF_LISTS'] = ([], [])
./ISI_BS_ST2.py:ISOLATION_CONSTANTS['CART_BIAS_DOF_LISTS'] = ([], [])
./ISI_ETMX_ST1.py:ISOLATION_CONSTANTS['CART_BIAS_DOF_LISTS'] = ([], [])
./ISI_ETMX_ST2.py:ISOLATION_CONSTANTS['CART_BIAS_DOF_LISTS'] = ([],[])
./ISI_ETMY_ST1.py:ISOLATION_CONSTANTS['CART_BIAS_DOF_LISTS'] = ([], [])
./ISI_ETMY_ST2.py:ISOLATION_CONSTANTS['CART_BIAS_DOF_LISTS'] = ([],[])
./ISI_HAM2.py:ISOLATION_CONSTANTS['CART_BIAS_DOF_LISTS'] = ([], ['X', 'Y', 'Z', 'RX', 'RY', 'RZ'])
./ISI_HAM4.py:ISOLATION_CONSTANTS['CART_BIAS_DOF_LISTS'] = ([], ['X', 'Y', 'Z', 'RX', 'RY', 'RZ'])
./ISI_HAM5.py:ISOLATION_CONSTANTS['CART_BIAS_DOF_LISTS'] = ([], ['X', 'Y', 'Z', 'RX', 'RY', 'RZ'])
./ISI_HAM6.py:ISOLATION_CONSTANTS['CART_BIAS_DOF_LISTS'] = ([], ['X', 'Y', 'Z', 'RX', 'RY', 'RZ'])
./ISI_ITMX_ST1.py:ISOLATION_CONSTANTS['CART_BIAS_DOF_LISTS'] = ([], [])
./ISI_ITMX_ST2.py:ISOLATION_CONSTANTS['CART_BIAS_DOF_LISTS'] = ([],[])
./ISI_ITMY_ST1.py:ISOLATION_CONSTANTS['CART_BIAS_DOF_LISTS'] = ([], [])
./ISI_ITMY_ST2.py:ISOLATION_CONSTANTS['CART_BIAS_DOF_LISTS'] = ([],[])
 

So it seems that we only restore the bias on HAMs 2,4,5,6. Doing this for L1 shows all empty lists, if the version we have is up to date.

After talking to JIm, he suggests that we change the "default" value to be an empty list, to avoid any possible future mishaps. Just to reiterate though, it is currently not restoring any biases on any of the BSCs, only HAMs 2,4,5,6.

jameson.rollins@LIGO.ORG - 14:28, Friday 17 June 2016 (27812)

TJ's analysis is correct: the default is what's defined in the isiguardianlib/isolation/CONST.py, which currently specifies that the RZ cart bias should be restored during the second phase of the isolation.

You can change the default in the CONST.py, but any change has to be well corrdinated with LLO, since that configuration is common for them as well.

hugh.radkins@LIGO.ORG - 10:16, Monday 20 June 2016 (27850)

TJ missed HAM3 in the list of platforms restoring biases.  This miss of the grep is likely from some h1 files being in the common area rather than the H1 directory.

Displaying report 1-1 of 1.