Reports until 15:16, Monday 14 January 2019
H1 CAL (CAL)
jeffrey.kissel@LIGO.ORG - posted 15:16, Monday 14 January 2019 (46405)
Bug in Time-Dependent Correction Factor Smoothing
J. Betzwieser, E. Goetz, J. Kissel

During the prep for install of all the new infrastructure for the O3-level calibration front-end model upgrades at LLO, they discovered another flaw / bug from me. This time, it's a copy-and-paste error with the smoothing process for the time-dependent correction factors. 

The *design* is to have every raw TDCF, computed in the simulink library
    /opt/rtcds/userapps/release/cal/common/models/CAL_LINE_MONITOR_MASTER.mdl
should be fed into three conditioning processes:
(1) a gate function,
    /opt/rtcds/userapps/release/cds/common/src/COH_GATE.c
(2) a median function,
    /opt/rtcds/userapps/release/cds/common/src/BUFFER_AND_MEDIAN.c
(3) and an average function,
    /opt/rtcds/userapps/release/cds/common/src/BUFFER_AND_AVERAGE.c

The way one sets these function calls is by changing the text inside the properties of the block. Like was the problem with the other user-created library parts (see LHO aLOG 46260), these blocks were renamed and -- until today -- the description was hidden, so it was easy for me to miss this copy and paste. Thus, I had mistakenly conditioned each of the TDCFs with Gate, Median, and Median, instead of Gate, Median, and Average.

The library has now been changed, the blocks are now annoted, the h1calcs model compiles successfully, and the above mentioned library part has been committed to the svn in the above descripbed location.

The intent is to install this fix tomorrow. It should not require a DAQ restart.


Images attached to this report