WP11314 Ramped CP1 fill
Gerardo, Richard, Travis, Jordan, Dave:
My code change was not ready for today's 10:00 fill, so we did one at the old time of 13:15.
Gerardo confirmed this was a good fill curbside.
New code summary:
Opening the LLCV is now ramped over 5 minutes
Closing is still as fast as the valve can move.
The code change details:
New PV added to IOC: H1:VAC-CP1_OVERFILL_LLCV_RAMP_TIME_SECONDS
The YAML configuration file parser now reads a new llcv_ramp_time_seconds line (default is 0)
At time of fill, instead of setting the LLCV to MAX_VAL as part of the pre-fill, it now overwrites the starting value to test caput is working.
In the fill loop, if the run_time is within the ramp_time, the LLCV is ramped to the next value.
If ramp time=0, the LLCV is set to the MAX_VAL in one caput, identical to pre-ramp code.
If during the ramping an end-of-fill condition is detected (cancel, fill-completed, TC failure, discharge line pressure out-of-bounds) the fill is stopped and LLCV returned to starting position.
Note that opening the LLCV is ramped, but closing it back to the starting value is still done with a single write (prevents excessive LN2 loss when overflowing).
Attached trends show both the standard logarithmic version, and a linear one zoomed in to show the new ramp
Adding a DetChar tag, to see if this change affects the range drop that had been reported by Marissa (alog 71301).