Reports until 15:18, Thursday 14 March 2024
H1 SUS (CDS, GRD)
jeffrey.kissel@LIGO.ORG - posted 15:18, Thursday 14 March 2024 (76389)
On the edits to python code to support ETM / TMS Watchdog Upgrades
J. Kissel, O. Patane, R. Short

One last aLOG about Tuesday's upgrade to the ETM and TMS watchdog system -- this time related to the python infrastructure surrounding the watchdog. That means two things:
    (1) The SUS guardian code, which is primarily driven by the code generic to all suspensions,
            /opt/rtcds/userapps/release/sus/common/scripts/
                sustools.py
        has a dictionary in it that defines whether to look for USER DACKILL channels. Since these were removed from EPICs, the ETM and TMS guardians threw connection errors after the model restarts.
        To resolve, we removed the "'USER': 'DACKILL', entries from the quadwd and tmtswd dictionary definitions around lines 1660 to 1670 of rev 23101.

        Unfortunately, because there's some incoming updates from L1 that we don't understand, we can't commit the changes.

    (2) There is python code underneath the hood of the "RESET ALL" button on the WD overview MEDM screens,
            /opt/rtcds/userapps/release/sus/common/scripts/
                wdreset_all.py
        In the old system, that python code pushes the (one) reset button (channel) that untrips all of the user watchdogs, as well as pressing the reset button (channel) on the USER DACKILL. 
            ezca['SUS-' + optic + '_WD_RESET'] = 1

            ezca['SUS-' + optic + '_DACKILL_RESET'] = 1
        Now that there no longer exists a USER DACKILL button to press on the ETMs and TMS, and because the python script is called in the MEDM screen with an ampersand, the call to the script successfully resets the user watchdogs, but then quietly breaks/fails in the background.

        Not good coding in practice, but not an impactful at this point. Indeed, because this is also common code to all suspension MEDM screens, the reset of the DACKILL is still *needed* for any suspensions that haven't yet had this upgrade. So, for now, we leave this ugly thing too.