Displaying report 1-1 of 1.
Reports until 12:16, Thursday 27 August 2026
H1 SPI
jeffrey.kissel@LIGO.ORG - posted 12:16, Thursday 27 August 2026 (91709)
Fixed links to SPI_LIBRARY in h1spih23 model; hetdemod.mdl now integrated into SPI_LIBRARY and correctly referenced in HET_IFO_SPD
J. Kissel, J. Wright, D. Barker

Dave tried compiling the h1spih23 model in prep to install my changes described in LHO:91705, and found there were no changes. Upon close inspection, the top-level model,
    /opt/rtcds/userapps/release/spi/h1/models/
        h1spih23.mdl
had it's link to the primary library "HJK" block in the 
    /opt/rtcds/userapps/release/spi/common/models/
        SPI_LIBRARY.mdl
and the link to Jennie's 
    /opt/rtcds/userapps/release/spi/common/models/
        hetdemod2.mdl
library part was also broken in the "HET_IFO_SPD" block of the SPI_LIBRARY. 

We believe these links got busted up when Jennie created and installed the hetdemod2.mdl part which flipped the assignment of SIN / COS to I / Q and removed the phase rotator block on Friday Aug 14 2026 (LHO:91543).

I've 
   (1) moved the block that was inside the hetdemod2.mdl file in to the SPI library, breaking the link to the hetdemod2.mdl library in the process so it's it's own fresh new library block solely within SPI_LIBRARY.mdl.
   (2) deleted the broken link to the hetdemod2.mdl version of the demod block in the HET_IFO_SPD block, and replaced it with the version now in the SPI_LIBRARY.mdl
   (3) deleted the instantiation of the top level library block HJK from the top level h1spih23 model, and then brought in a fresh copy from the SPI_LIBRARY.mdl (renaming it to H23 of course).
   (4) removed hetdemod.mdl from the svn so there's no longer any confusion as to where this block comes from, and the SPI_LIBRARY.mdl returns to being self-contained.
i.e. I resolved all of these broken links, and committed everything anew to the svn with all links resolved, so it should have no functional change to the demodulation fix. 

Here's the svn commit log:

Committed SPI_LIBRARY fix with HETDEMOD correctly linked to HET_IFO_SPD, so that it's all self-contained and functional.
    /opt/rtcds/userapps/release/spi/common/models/
        SPI_LIBRARY.mdl
        r35942.

Deleted hetdemod.mdl, since it's now in the SPI_LIBRARY.
        [[no longer in the svn]]
        r35943.

Commited new top level model with the H23 block newly refreshed as a link to the HJK block in the SPI_LIBRARY.mdl.
    /opt/rtcds/userapps/release/spi/h1/models/
        h1spih23.mdl
        r35944.

Committed bug fix to DAQ Channel list in SPI_LIBRARY found during test compile (that wasn't found earlier because the library link to the HJK block was broken).
    /opt/rtcds/userapps/release/spi/common/models/
        SPI_LIBRARY.mdl
        35945.

Screenshot #1 shows how/where the HETDEMOD block now is integrated into the SPI_LIBRARY structure.
Screenshot #2 shows that the link to the SPI_LIBRARY HJK part is now alive and well in the h1spih23.mdl
Images attached to this report
Displaying report 1-1 of 1.